Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: LayerConfig.inner_dim default handling #8486

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix: LayerConfig.inner_dim default handling #8486

merged 1 commit into from
Nov 30, 2023

Conversation

RemyLau
Copy link
Contributor

@RemyLau RemyLau commented Nov 30, 2023 •
edited
Loading

@RemyLau RemyLau requested a review from JiaxuanYou as a code owner November 30, 2023 00:14
@RemyLau RemyLau changed the title fix: layer config inner dim default handling #8484 fix: layer config inner dim default handling Nov 30, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6d16f1) 88.36% compared to head (97da021) 88.37%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8486   +/-   ##
=======================================
  Coverage   88.36%   88.37%           
=======================================
  Files         478      478           
  Lines       29405    29405           
=======================================
+ Hits        25985    25987    +2     
+ Misses       3420     3418    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s rusty1s linked an issue Nov 30, 2023 that may be closed by this pull request
GraphGym MLP incorrect layer config #8484
Closed
@rusty1s rusty1s changed the title fix: layer config inner dim default handling Fix: LayerConfig.inner_dim default handling Nov 30, 2023
@rusty1s rusty1s enabled auto-merge (squash) November 30, 2023 07:09
@rusty1s rusty1s disabled auto-merge November 30, 2023 11:32
@rusty1s rusty1s merged commit f24d3a0 into pyg-team:master Nov 30, 2023
16 of 20 checks passed
@RemyLau RemyLau deleted the fix-graphgym-mlp branch November 30, 2023 15:44
@RemyLau RemyLau mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@JiaxuanYou JiaxuanYou Awaiting requested review from JiaxuanYou JiaxuanYou is a code owner

Assignees

@RemyLau RemyLau

Labels
0 - Priority P0 bug graphgym skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphGym MLP incorrect layer config
2 participants
@RemyLau @rusty1s