Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for HeteroData node indexing in LocalGraphStore and LocalFeatureStore #8438

Merged
merged 15 commits into from
Nov 29, 2023

Conversation

JakubPietrakIntel
Copy link
Contributor

To align partitioned data storage in LocalGraphStore and LocalFeatureStore with standard format for PyG HeteroData we need to keep indexing for the nodes of the same type separate, i.e. each node type has indices starting at 0 (rather than using global indexing for all).

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (408d23e) 87.71% compared to head (b88d096) 87.69%.

❗ Current head b88d096 differs from pull request most recent head 7c2cde8. Consider uploading reports for the commit 7c2cde8 to get more accurate results

Files Patch % Lines
torch_geometric/loader/cluster.py 85.71% 7 Missing ⚠️
torch_geometric/distributed/local_graph_store.py 14.28% 6 Missing ⚠️
torch_geometric/distributed/local_feature_store.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8438      +/-   ##
==========================================
- Coverage   87.71%   87.69%   -0.03%     
==========================================
  Files         478      478              
  Lines       29370    29400      +30     
==========================================
+ Hits        25763    25781      +18     
- Misses       3607     3619      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JakubPietrakIntel JakubPietrakIntel marked this pull request as ready for review November 24, 2023 13:36
@rusty1s rusty1s enabled auto-merge (squash) November 29, 2023 15:27
@rusty1s rusty1s merged commit 1ba2743 into master Nov 29, 2023
@rusty1s rusty1s deleted the jpietrak/dist_hetero_nodeid branch November 29, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants