-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for HeteroData
node indexing in LocalGraphStore
and LocalFeatureStore
#8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8438 +/- ##
==========================================
- Coverage 87.71% 87.69% -0.03%
==========================================
Files 478 478
Lines 29370 29400 +30
==========================================
+ Hits 25763 25781 +18
- Misses 3607 3619 +12 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
Co-authored-by: Kinga Gajdamowicz <kinga.gajdamowicz@intel.com> (cherry picked from commit fdaf800)
(cherry picked from commit 3d76159)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
rusty1s
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align partitioned data storage in
LocalGraphStore
andLocalFeatureStore
with standard format for PyGHeteroData
we need to keep indexing for the nodes of the same type separate, i.e. each node type has indices starting at 0 (rather than using global indexing for all).