Implemented the Learnable Communitive Monoid Aggregation #7976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7976 +/- ##
=======================================
Coverage 89.58% 89.58%
=======================================
Files 461 462 +1
Lines 26980 27018 +38
=======================================
+ Hits 24169 24205 +36
- Misses 2811 2813 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
overall LGTM, but lets wait on @wsad1 and/or @EdisonLeeeee reviews |
EdisonLeeeee
approved these changes
Sep 8, 2023
Co-authored-by: Jintang Li <cnljt@outlook.com>
Co-authored-by: Jintang Li <cnljt@outlook.com>
Co-authored-by: Jintang Li <cnljt@outlook.com>
rusty1s
approved these changes
Sep 11, 2023
JakubPietrakIntel
pushed a commit
that referenced
this pull request
Sep 27, 2023
Initial version of the LCM aggregation, requested in issue #7574. A possible feature to incorporate is for `forward` to additionally compute and return an associativity loss, as described in the paper. --------- Co-authored-by: Rishi Puri <puririshi98@berkeley.edu> Co-authored-by: Jintang Li <cnljt@outlook.com> Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
|
Why was the associativity loss not included? |
Hi @Kroppeb! I briefly attempted to implement associativity loss, but it wasn't as straightforward as commutativity loss and I never got around to finishing it. But good point - it should be available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of the LCM aggregation, requested in issue #7574. A possible feature to incorporate is for
forwardto additionally compute and return an associativity loss, as described in the paper.