Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing GraphGym Documentation #7885

Merged
merged 12 commits into from
Sep 1, 2023
Merged

Enhancing GraphGym Documentation #7885

merged 12 commits into from
Sep 1, 2023

Conversation

rajveer43
Copy link
Contributor

@rajveer43 rajveer43 commented Aug 16, 2023 •
edited by akihironitta
Loading

Part of #5132.

@rajveer43 rajveer43 requested a review from JiaxuanYou as a code owner August 16, 2023 06:03
@rajveer43
Copy link
Contributor Author

@rusty1s here is the PR...for the issue no #5132...your aasistance is required what should be added where should be added

@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #7885 (1a6870d) into master (a52af69) will decrease coverage by 0.77%.
The diff coverage is 61.79%.

@@            Coverage Diff             @@
##           master    #7885      +/-   ##
==========================================
- Coverage   90.19%   89.42%   -0.77%     
==========================================
  Files         459      459              
  Lines       26951    26948       -3     
==========================================
- Hits        24309    24099     -210     
- Misses       2642     2849     +207
Files Changed Coverage Δ
torch_geometric/graphgym/config.py 91.50% <0.00%> (ø)
...ch_geometric/graphgym/contrib/layer/generalconv.py 18.18% <0.00%> (-0.62%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️
torch_geometric/graphgym/utils/plot.py 0.00% <0.00%> (ø)
torch_geometric/graphgym/models/act.py 80.00% <37.50%> (ø)
torch_geometric/graphgym/loader.py 39.26% <40.00%> (+0.37%) ⬆️
torch_geometric/graphgym/models/head.py 49.20% <50.00%> (-0.80%) ⬇️
torch_geometric/graphgym/loss.py 60.86% <66.66%> (-1.64%) ⬇️
torch_geometric/graphgym/models/layer.py 72.48% <68.57%> (-0.64%) ⬇️
torch_geometric/graphgym/init.py 44.44% <75.00%> (ø)
... and 4 more

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s changed the title Enhancing GraphGym Integration with PyTorch Geometric: PyTorch Lightning and Hydra Integration Enhancing GraphGym Integration Aug 16, 2023
@rajveer43
Copy link
Contributor Author

@rusty1s Can you explain more on this so I can work better and implement things fully!

akihironitta
akihironitta reviewed Aug 26, 2023
View reviewed changes
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rajveer43 thank you for working on this! I think we can merge this as a docs improvement PR once we address the CI failures. Would you mind having a look?

@rajveer43
Copy link
Contributor Author

rajveer43 commented Aug 27, 2023 •
edited
Loading

Hi @rajveer43 thank you for working on this! I think we can merge this as a docs improvement PR once we address the CI failures. Would you mind having a look?

Sure I will look into this! I need some more insights, What to change in other files related to graph Gym Would you elaborate more?

akihironitta
akihironitta reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajveer43 I'm happy to help in a follow-up PR. Which subtask listed in #5132 are you interested in working on next?

@rajveer43
Copy link
Contributor Author

@rajveer43 I'm happy to help in a follow-up PR. Which subtask listed in #5132 are you interested in working on next?

sure

@rajveer43 rajveer43 requested a review from akihironitta August 31, 2023 14:25
@rajveer43
Copy link
Contributor Author

Hi @rajveer43 thank you for working on this! I think we can merge this as a docs improvement PR once we address the CI failures. Would you mind having a look?

make html does not work on windows. and I am not getting why CI checks faling. saw the workflow run. but could not get it could you explain!

@rusty1s rusty1s changed the title Enhancing GraphGym Integration Enhancing GraphGym Documentation Sep 1, 2023
@rusty1s rusty1s enabled auto-merge (squash) September 1, 2023 11:37
@rusty1s rusty1s merged commit 7a6052c into pyg-team:master Sep 1, 2023
JakubPietrakIntel pushed a commit that referenced this pull request Sep 27, 2023
@rajveer43 @pre-commit-ci
@rusty1s @JakubPietrakIntel
Enhancing GraphGym Documentation (#7885)
db1bbe4 
Part of #5132.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: rusty1s <matthias.fey@tu-dortmund.de>
@RemyLau RemyLau mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@JiaxuanYou JiaxuanYou Awaiting requested review from JiaxuanYou JiaxuanYou is a code owner

@akihironitta akihironitta Awaiting requested review from akihironitta

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

Assignees

@rajveer43 rajveer43

Labels
0 - Priority P0 documentation feature graphgym skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajveer43 @rusty1s @akihironitta