-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Coverage] loader/test_dataloader.py
#6648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for torch_geometric.loader.dataloader.Collater only covered inputs of type List[torch_geometric.data.Data] and List[torch_geometric.data.HeteroData]. This commit adds a testing function that tests inputs of List[torch.Tensor], ]List[int], List[float], List[Mapping], List[tuple], and List[Sequence].
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #6648 +/- ##
==========================================
+ Coverage 87.76% 87.81% +0.04%
==========================================
Files 422 422
Lines 22906 22907 +1
==========================================
+ Hits 20103 20115 +12
+ Misses 2803 2792 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wsad1
reviewed
Feb 9, 2023
wsad1
reviewed
Feb 9, 2023
wsad1
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tests for DataLoader and Collater only covered input datasets composed of Data or HeteroData. This commit adds a testing function that tests inputs of type: