Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fidelity metric and assigning edge masks as tensors #6510

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Jan 25, 2023

No description provided.

@rusty1s rusty1s linked an issue Jan 25, 2023 that may be closed by this pull request
@rusty1s rusty1s self-assigned this Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #6510 (51bb206) into master (a7a5fd2) will decrease coverage by 1.75%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #6510      +/-   ##
==========================================
- Coverage   87.42%   85.68%   -1.75%     
==========================================
  Files         406      406              
  Lines       22694    22659      -35     
==========================================
- Hits        19840    19415     -425     
- Misses       2854     3244     +390     
Impacted Files Coverage Δ
torch_geometric/explain/metric/fidelity.py 100.00% <ø> (ø)
torch_geometric/explain/algorithm/utils.py 96.77% <75.00%> (-3.23%) ⬇️
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 17.84% <0.00%> (-49.66%) ⬇️
torch_geometric/visualization/graph.py 68.25% <0.00%> (-26.99%) ⬇️
torch_geometric/profile/profile.py 33.33% <0.00%> (-25.39%) ⬇️
torch_geometric/nn/conv/utils/typing.py 83.75% <0.00%> (-15.00%) ⬇️
torch_geometric/nn/pool/asap.py 92.00% <0.00%> (-8.00%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/resolver.py 82.75% <0.00%> (-6.90%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit ca20152 into master Jan 25, 2023
@rusty1s rusty1s deleted the fix_fidelity branch January 25, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fidelity calculation requires '_edge_mask' as parameter
1 participant