-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix graphgym example for activation functions #5243
Merged
Padarn
merged 9 commits into
pyg-team:master
from
M-Lampert:fix-graphgym-example-activations
Aug 20, 2022
Merged
Fix graphgym example for activation functions #5243
Padarn
merged 9 commits into
pyg-team:master
from
M-Lampert:fix-graphgym-example-activations
Aug 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5243 +/- ##
==========================================
- Coverage 83.15% 83.04% -0.12%
==========================================
Files 337 337
Lines 18574 18574
==========================================
- Hits 15445 15424 -21
- Misses 3129 3150 +21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Padarn
reviewed
Aug 20, 2022
Padarn
reviewed
Aug 20, 2022
Padarn
reviewed
Aug 20, 2022
accidentally committed a suggestion to the branch
Padarn
reviewed
Aug 20, 2022
rusty1s
approved these changes
Aug 20, 2022
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Padarn
reviewed
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you choose one of the given example activation functions (
swish
orlrelu_03
) you get the following error:This happens because the classes are initialized before registering and
layer.py
later tries to initialize them again.My proposal: Use
partial
to specify the arguments without initializing the class.