-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect flow
argument in GCN
normalization
#5149
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5149 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 333 333
Lines 18365 18367 +2
=======================================
+ Hits 15240 15242 +2
Misses 3125 3125
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
flow
argument in GCN
normalization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Co-authored-by: Jinu Sunil <jinu.sunil@gmail.com>
@wsad1 I have updated the changelog and merged from master. 1 unrelated test is failing ( |
Thanks @gau-nernst. Also added the |
Add flow to
gcn_norm
to correctly normalize adjacency matrix whenflow=target_to_source
for directed graphs. This is discussed in #5100.A simple test is added to verify this new behavior.
@rusty1s Let me know if you need me to edit any thing.