LinkNeighborLoader: Support edge_label_time
#5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusty1s
changed the title
LinkNeigbhborLoader: Support edge_time.LinkNeigbhborLoader: Support edge_time
Codecov Report
@@ Coverage Diff @@
## master #5137 +/- ##
==========================================
+ Coverage 82.98% 83.04% +0.05%
==========================================
Files 333 333
Lines 18371 18403 +32
==========================================
+ Hits 15246 15282 +36
+ Misses 3125 3121 -4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
rusty1s
changed the title
LinkNeigbhborLoader: Support edge_timeLinkNeighborLoader: Support edge_time
|
FYI the linked issue is in a private repo |
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
reviewed
Aug 6, 2022
Padarn
requested changes
Aug 6, 2022
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
Co-authored-by: Padarn Wilson <padarn.wilson@grabtaxi.com>
…nto link_time_attr
rusty1s
reviewed
Aug 9, 2022
rusty1s
changed the title
LinkNeighborLoader: Support edge_timeLinkNeighborLoader: Support edge_label_time
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
for more information, see https://pre-commit.ci
rusty1s
reviewed
Aug 10, 2022
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
for more information, see https://pre-commit.ci
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
for more information, see https://pre-commit.ci
…nto link_time_attr
rusty1s
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR users can pass an
edge_timetoLinkNeighborLoader, and sampling will respect theedge_time.