-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default splits to MalNetTiny
dataset
#5078
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5078 +/- ##
==========================================
- Coverage 84.88% 82.98% -1.90%
==========================================
Files 333 333
Lines 18375 18371 -4
==========================================
- Hits 15598 15246 -352
- Misses 2777 3125 +348
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Padarn
reviewed
Jul 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me
MalNetTiny
dataset
Padarn
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I modified the
MalNetTiny
so that it now downloads also the official split information given by the authors. I also removed a previously addedremove_isolated_nodes()
from the process (added in #3592), that I believe it should be done as a transform/pre-transform (withRemoveIsolatedNodes
), if needed by the user. This may be reverted, if you think otherwise!The code now add the graphs not in alphabetical order, but in the order defined by the split files. One should be able to easily extend the
MalNetTiny
class to the full datasetMalNet
just by modifyingself.data_url
,self.split_url
,self.raw_file_names()
andself.download()
. I could not try it since I do not have enough space at the moment (the full data is about 130GB).Francesco