Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SoftmaxAggregation and PowerMeanAggregation doc strings #5036

Merged
merged 8 commits into from
Jul 23, 2022

Conversation

lightaime
Copy link
Contributor

This PR updates the docs strings of SoftmaxAggregation and PowerMeanAggregation.

Addresses #4712.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #5036 (13efae4) into master (6864a1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5036   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files         331      331           
  Lines       18158    18158           
=======================================
  Hits        15041    15041           
  Misses       3117     3117           
Impacted Files Coverage Δ
torch_geometric/nn/aggr/basic.py 97.29% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is indeed cleaner :)

@rusty1s rusty1s changed the title Update SoftmaxAggregation and PowerMeanAggregation docs strings Update SoftmaxAggregation and PowerMeanAggregation doc strings Jul 23, 2022
lightaime and others added 6 commits July 23, 2022 17:04
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@lightaime lightaime merged commit 6ed5caf into master Jul 23, 2022
@lightaime lightaime deleted the gen_aggr_docs branch July 23, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants