Move nn.glob.attention.GlobalAttention to nn.aggr.attention.AttentionalAggregation
#4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Codecov Report
@@ Coverage Diff @@
## master #4986 +/- ##
=======================================
Coverage 82.79% 82.79%
=======================================
Files 330 330
Lines 17978 17978
=======================================
Hits 14885 14885
Misses 3093 3093
Continue to review full report at Codecov.
|
rusty1s
approved these changes
Jul 15, 2022
test/nn/aggr/test_attention.py
Outdated
| index = index.view(-1, 1).repeat(1, dim_size).view(-1) | ||
|
|
||
| assert aggr(x, index).size() == (dim_size, channels) | ||
| assert aggr(x, index, |
There was a problem hiding this comment.
Test
out = aggr(x, index)
assert out.size() == (dim_size, channels)
torch.allclose(aggr(x, index, dim_size=dim_size), out)instead.
There was a problem hiding this comment.
I added this, but just to confirm you want to make surer that the output does not change if dim_size is provided? Maybe it would be better to test
out = aggr(x, index)
assert out.size() == (dim_size, channels)
torch.allclose(aggr(x, index, dim_size=dim_size + 1)[:3], out)
WDYT?
|
Thanks for the comments @rusty1s! |
rusty1s
changed the title
nn.glob.attention.GlobalAttention to nn.aggr.attention.AttentionAggregationnn.glob.attention.GlobalAttention to nn.aggr.attention.AttentionalAggregation
rusty1s
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4712