Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added time_attr to LinkNeighborLoader #4877

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Added time_attr to LinkNeighborLoader #4877

merged 7 commits into from
Jun 28, 2022

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Jun 28, 2022 •
edited
Loading

This PR make the following changes.

  1. Adds time_attr to LinkNeighborLoader
  2. Refactors NeigbhorSampler and LinkNeighborSampler. Common code is moved to _sparse_neighbor_sampler and hetero_sparse_neighbor_sampler.

@wsad1 wsad1 marked this pull request as draft June 28, 2022 10:47
@wsad1 wsad1 changed the title [WIP]: added time_attr to link_neighbor_loader. [WIP]: Added time_attr to LinkNeighborLoader. Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

Merging #4877 (19879c3) into master (0f7e018) will not change coverage.
The diff coverage is 81.25%.

@@           Coverage Diff           @@
##           master    #4877   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         329      329           
  Lines       17703    17703           
=======================================
  Hits        14652    14652           
  Misses       3051     3051
Impacted Files Coverage Δ
torch_geometric/loader/neighbor_loader.py 86.44% <78.57%> (+0.31%) ⬆️
torch_geometric/loader/link_neighbor_loader.py 91.85% <100.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f7e018...19879c3. Read the comment docs.

@wsad1 wsad1 marked this pull request as ready for review June 28, 2022 11:25
@wsad1 wsad1 changed the title [WIP]: Added time_attr to LinkNeighborLoader. Added time_attr to LinkNeighborLoader. Jun 28, 2022
@wsad1 wsad1 requested review from Padarn and RexYing June 28, 2022 11:25
@rusty1s rusty1s changed the title Added time_attr to LinkNeighborLoader. Added time_attr to LinkNeighborLoader Jun 28, 2022
rusty1s
rusty1s approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool and clean. Thank you!

@rusty1s
Copy link
Member

rusty1s commented Jun 28, 2022

Please add to CHANGELOG.md as well :)

wsad1 and others added 2 commits June 28, 2022 19:11
@wsad1 @rusty1s
Update torch_geometric/loader/link_neighbor_loader.py
3f1ca76 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@wsad1 @rusty1s
add type hint.
0c08fd7 
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
@wsad1 wsad1 removed the request for review from RexYing June 28, 2022 13:43
@rusty1s rusty1s merged commit cfda074 into pyg-team:master Jun 28, 2022
@Padarn
Copy link
Contributor

Padarn commented Jun 28, 2022

This is nice. Thanks!

@wsad1 wsad1 deleted the link_time_attr branch July 22, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@Padarn Padarn Awaiting requested review from Padarn

Assignees

@wsad1 wsad1

Labels
1 - Priority P1 feature loader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsad1 @rusty1s @Padarn