Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporal sampling support to NeighborLoader #4025

Merged
merged 18 commits into from
Apr 25, 2022
Merged

Conversation

RexYing
Copy link
Contributor

@RexYing RexYing commented Feb 8, 2022

not sure how to use the parameterize thing yet.

I was trying
@pytest.mark.parametrize('directed', [True, False])
@pytest.mark.parametrize('temporal', [True, False])
but didn't work. Will look into it further.

@rusty1s
Copy link
Member

rusty1s commented Feb 8, 2022

I was trying
@pytest.mark.parametrize('directed', [True, False])
@pytest.mark.parametrize('temporal', [True, False])
but didn't work. Will look into it further.

This should work, but keep in mind to add both directed and temporal to the function signature.

@rusty1s rusty1s self-requested a review February 8, 2022 08:24
@rusty1s rusty1s changed the title temporal loader Add temporal sampling support to NeighborLoader Feb 8, 2022
@rusty1s rusty1s added the loader label Apr 22, 2022
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good! Left some last comments.

RexYing and others added 4 commits April 24, 2022 16:46
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #4025 (fb680be) into master (c3d1ac5) will decrease coverage by 0.12%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #4025      +/-   ##
==========================================
- Coverage   82.83%   82.71%   -0.13%     
==========================================
  Files         313      313              
  Lines       16343    16361      +18     
==========================================
- Hits        13538    13533       -5     
- Misses       2805     2828      +23     
Impacted Files Coverage Δ
torch_geometric/data/lightning_datamodule.py 26.08% <ø> (ø)
torch_geometric/loader/neighbor_loader.py 91.83% <75.00%> (-2.61%) ⬇️
torch_geometric/testing.py 96.66% <91.66%> (-3.34%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/io/tu.py 93.58% <0.00%> (-2.57%) ⬇️
torch_geometric/nn/models/mlp.py 98.41% <0.00%> (-1.59%) ⬇️
torch_geometric/transforms/gdc.py 78.17% <0.00%> (-1.02%) ⬇️
torch_geometric/data/dataset.py 96.80% <0.00%> (-0.80%) ⬇️
torch_geometric/nn/conv/rgat_conv.py 83.76% <0.00%> (-0.53%) ⬇️
torch_geometric/graphgym/utils/comp_budget.py 15.51% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d1ac5...fb680be. Read the comment docs.

@rusty1s rusty1s merged commit b0cec1d into master Apr 25, 2022
@rusty1s rusty1s deleted the temporal_sampling branch April 25, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants