-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temporal sampling support to NeighborLoader
#4025
Conversation
This should work, but keep in mind to add both |
NeighborLoader
…r temporal sampling
Co-authored-by: Matthias Fey <matthias.fey@tu-dortmund.de>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! Left some last comments.
Codecov Report
@@ Coverage Diff @@
## master #4025 +/- ##
==========================================
- Coverage 82.83% 82.71% -0.13%
==========================================
Files 313 313
Lines 16343 16361 +18
==========================================
- Hits 13538 13533 -5
- Misses 2805 2828 +23
Continue to review full report at Codecov.
|
not sure how to use the parameterize thing yet.
I was trying
@pytest.mark.parametrize('directed', [True, False])
@pytest.mark.parametrize('temporal', [True, False])
but didn't work. Will look into it further.