Improve .llm code coverage#10516
Conversation
xnuohz
requested review from
akihironitta,
puririshi98,
rusty1s and
wsad1
as code owners
xnuohz
changed the title
.llm code coveragellm/models/sentence_transformer.py and llm/models/vision_transformer.py
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #10516 +/- ##
==========================================
- Coverage 86.11% 84.19% -1.92%
==========================================
Files 496 510 +14
Lines 33655 36013 +2358
==========================================
+ Hits 28981 30321 +1340
- Misses 4674 5692 +1018 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xnuohz
changed the title
llm/models/sentence_transformer.py and llm/models/vision_transformer.py.llm code coverage
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
@xnuohz Thank you for the changes! I will take care of the rest during some weekend.
for more information, see https://pre-commit.ci
akihironitta
left a comment
akihironitta
left a comment
There was a problem hiding this comment.
@xnuohz Looks like some rag tests are failing. Once they're fixed, this PR will be ready for merging. Mind taking care of the test failures? Thank you again for your contribution and patience!
|
@akihironitta fixed test failures, code coverage not upload. can you help resolve this and merge? |
Yes, it's expected. I'd suggest we follow up separately. |
3 participants
Issue
Close #10514, #10529, #9660, #9675
CodeCov
Before
After