Improve performance of Encoder's na_forward
method
#364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces small improvements that resulted in an average 1.5x speedup in
na_forward
execution time.get_na_mask
is a heavy operation, whose result may be cached at the pre-condition checking step.Additionally, when we deal with 2D
feat
, we can usetorch.where
to efficiently fillNaN
s across all columns.