Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support decoder text embedding model in the examples/transformers_text.py #333

Merged
merged 17 commits into from
Jan 11, 2024

Conversation

zechengz
Copy link
Member

@zechengz zechengz commented Jan 8, 2024

Support state-of-the-art decoder text embedding model (intfloat/e5-mistral-7b-instruct) in the examples/transformers_text.py
This is currently top 1 text embedding model (outperforms Voyage AI and OpenAI's embedding models)

@zechengz zechengz requested a review from weihua916 January 8, 2024 07:43
@zechengz zechengz self-assigned this Jan 8, 2024
@zechengz zechengz changed the title Support state-of-the-art decoder embedding model in the examples/transformers_text.py Support decoder text embedding model in the examples/transformers_text.py Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46e20d5) 93.12% compared to head (aa51b88) 93.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files         117      117           
  Lines        6107     6107           
=======================================
  Hits         5687     5687           
  Misses        420      420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zechengz zechengz marked this pull request as ready for review January 8, 2024 07:46
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. beautiful and nice results!!

Left some questions and minor comments.

examples/transformers_text.py Show resolved Hide resolved
examples/transformers_text.py Show resolved Hide resolved
examples/transformers_text.py Outdated Show resolved Hide resolved
examples/transformers_text.py Outdated Show resolved Hide resolved
examples/transformers_text.py Outdated Show resolved Hide resolved
examples/transformers_text.py Outdated Show resolved Hide resolved
examples/transformers_text.py Outdated Show resolved Hide resolved
@zechengz zechengz requested a review from weihua916 January 9, 2024 06:39
Copy link
Contributor

@weihua916 weihua916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

examples/transformers_text.py Show resolved Hide resolved
examples/transformers_text.py Show resolved Hide resolved
@zechengz zechengz merged commit a22bb92 into master Jan 11, 2024
13 checks passed
@zechengz zechengz deleted the zecheng_text_example_update branch January 11, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants