Orbital / EMP S menu item incorrect

[blitzmann]

Should look like this:

Also, look into removing Item from charge list. Makes it look like the charges are supposed to be grouped Nevermind, I'm an idiot

[blitzmann]

This is happening because :ccp:. Orbital ammo is called:

• Orbital EMP S
• Orbital Laser S
• Orbital Hybrid S

The way Pyfa groups ammo, it takes the last two words of the ammo ("EMP S" from "Republic Fleet EMP S") and groups them together. For lasers and hybrids, they have a unique name. For projectile, it's not called Projectile, instead it's called an already used name.

Fix for this is simply to check to see if "Orbital" is in the name, and to add it without any other checking for submenus. If CCP adds more orbital ammo, this will need to be tweaked.

[DarkFenX]

Does this ammo have any real use-cases? It seems to have zero dps and doesn't change any stats. Players may know that it's loadable in small projectiles, so maybe hide it altogether (at least from ammo picker, leave it in market group so it can be loaded via double-click)?

[blitzmann]

Actually, no, it doesn't have any use for EVE itself, and is completely useless to load. The only change is range bonus (for projectiles, at least), but since you can't use it on ships, this makes no difference.

I agree that it would be a good idea to hide it from the ammo picker. The only reason to keep it there would be for completeness (and the fact users might reports it missing being a bug), but I think that removing it will be okay as long as it's still loadable for those that want it for fit exports or whatnot. I'll reopen issue until that's done.

[DarkFenX]

In this case we could just hide it completely via market overrides. If we get reports that it's missing then we can do something with it.