Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation crashes if Pyfa is already open #120

Closed
blitzmann opened this issue Jun 5, 2014 · 1 comment
Closed

Installation crashes if Pyfa is already open #120

blitzmann opened this issue Jun 5, 2014 · 1 comment

Comments

@blitzmann
Copy link
Collaborator

  1. Open Pyfa
  2. Try to install with .exe to the currently opened pyfa's location

this shows:
screen1

You accept the option, and then the installation hangs on:
screen2

Unsure if this has always been an issue or if it's with recent release.
@blitzmann
Copy link
Collaborator Author

I looked into this today. Windows event log is giving a Application or service 'pyfa.exe' could not be shut down.. I have no idea why.

I got around this by adding to the Inno Setup Script a function I found online that will halt the installation if pyfa is found to be running. It doesn't give the user an option to "restart" (which is where it was crashing), it just tells the user to stop pyfa, go back, and try again. See here:

https://gist.github.com/blitzmann/4bf7fcf96880d14d75b6

blitzmann added a commit to blitzmann/Pyfa that referenced this issue Oct 13, 2014
@blitzmann
Fix pyfa-org#120
7005640
w9jds pushed a commit to w9jds/Pyfa that referenced this issue Aug 14, 2017
@Ebag333
Merge pull request pyfa-org#120 from Pyfa-fit/catchup
4b356d7 
Catchup: Various bugfixes and logging enhancements from Pyfa-org
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blitzmann