Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 3, 2020

reference: pyexcel/pyexcel-io#80

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please add yourself to 'contributors' section of pyexcel-xlsxw.yml (if not found, please use CONTRIBUTORS.rst)
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #7 into dev will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev       #7   +/-   ##
=======================================
  Coverage   98.15%   98.16%           
=======================================
  Files           8        8           
  Lines         380      381    +1     
=======================================
+ Hits          373      374    +1     
  Misses          7        7           
Impacted Files Coverage Δ
pyexcel_xlsxw/__init__.py 100.00% <100.00%> (ø)
pyexcel_xlsxw/xlsxw.py 100.00% <100.00%> (ø)
tests/base.py 98.18% <100.00%> (ø)
tests/test_bug_fixes.py 100.00% <100.00%> (ø)
tests/test_formatters.py 100.00% <100.00%> (ø)
tests/test_multiple_sheets.py 97.12% <100.00%> (ø)
tests/test_stringio.py 100.00% <100.00%> (ø)
tests/test_writer.py 97.14% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9bb33f...1306048. Read the comment docs.

@chfw chfw merged commit bf0e271 into dev Oct 3, 2020
@chfw chfw deleted the new-style-reader-writer branch October 3, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants