Skip to content

Conversation

@chfw
Copy link
Member

@chfw chfw commented Oct 3, 2020

reference: pyexcel/pyexcel-io#80

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@3ee118c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev       #6   +/-   ##
======================================
  Coverage       ?   91.13%           
======================================
  Files          ?       11           
  Lines          ?      485           
  Branches       ?        0           
======================================
  Hits           ?      442           
  Misses         ?       43           
  Partials       ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee118c...a9e0612. Read the comment docs.

@chfw chfw merged commit 21d2903 into dev Oct 3, 2020
@chfw chfw deleted the new-style-reader branch October 3, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants