Skip to content

Fix column_to_number being incorrect for files with more than 26 columns #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2025
Merged

Fix column_to_number being incorrect for files with more than 26 columns #13

merged 3 commits into from
Oct 31, 2025

Conversation

@PLPeeters
Copy link
Contributor

@PLPeeters PLPeeters commented Oct 30, 2025

The current column_to_number function is completely broken for files with more than 26 columns.

This PR contains:

  • A fix for the above
  • A migration of the tests to pytest

With your PR, here is a check list:

  • Has test cases written?
  • Has all code lines tested?
  • Has make format been run?
  • Please update CHANGELOG.yml(not CHANGELOG.rst)
  • Has fair amount of documentation if your change is complex
  • Agree on NEW BSD License for your contribution

Pierre-Louis Peeters added 3 commits October 30, 2025 15:44
Migrate tests to pytest
426879c
Fix column_to_number and memoize it
718d358 
The function failed for files with more than 26 columns
Update changelog
0f15592
@chfw chfw merged commit 361a421 into pyexcel:dev Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PLPeeters @chfw