Skip to content

Conversation

@T90REAL
Copy link

@T90REAL T90REAL commented Nov 25, 2025

Solve #628.
Fix compare_paths_lt to align with Python’s strict ordering contract.

@funkyfuture
Copy link
Member

please provide tests that have a practical impact where you prove that the current implementation isn't sufficient.

if you propose such a significant change, also add tests that cover the possible edge cases between the current state and your proposal, so we can be sure that the current sorting behaviour persists.

then (again), i don't know where you take that strong contract from and why you think it would be mandatory in that case.

@T90REAL
Copy link
Author

T90REAL commented Dec 1, 2025

Thanks for your response. My original thought is that if err < err == True would cause some function does not work as designed, for example the bisect_left function. After reconsidering the context, I agree it doesn’t have a significant impact on the behavior. I’ll close the PR here, sorry for the noise.

@T90REAL T90REAL closed this Dec 1, 2025
@funkyfuture
Copy link
Member

well, let's consider this an academic exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants