Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease memory consumption, use importlib.metadata to get package version instead of pkg_resources.get_dictribution #579

Closed

Conversation

akayunov
Copy link

@akayunov akayunov commented Oct 5, 2021

pkg_resources use a lot of memory and after introducing importlib.metadata in 3.8 looks obsolete. So let's change way to get package version and get rid of pkg_resources import.

@akayunov
Copy link
Author

akayunov commented Oct 6, 2021

Do we really need tests like these: cerberus/tests/test_assorted.py:23?

@funkyfuture
Copy link
Member

thanks for bringing this up. i think this would be well covered as the test suite runs on all supported platforms.

could you please check whether the importlib_metadata object could be defined in and imported from the platform module?

you may have noticed that development has stalled for a while and it will take such to merge and release this pr.

@funkyfuture
Copy link
Member

oh, iirc this test is covering some edge case. please try to do some research in the commit / pr / issues history.

@slanzmich
Copy link

Is there any chance to get this merged and released? If yes, I can provide a fix for the tests in cerberus/tests/test_assorted.py.

@evelikov
Copy link

@funkyfuture sorry to bother, but can we get this merged (or variation thereof) and a new release? Thanks in advance

@pyeve pyeve deleted a comment from socketpair Jul 22, 2023
@pyeve pyeve deleted a comment from socketpair Jul 22, 2023
@funkyfuture
Copy link
Member

solved w/ 81e2dfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants