Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ruff/flake8-type-checking rules (TCH) #9728

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enforce ruff/flake8-type-checking rules (TCH) #9728

wants to merge 4 commits into from
+234 −141

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

max-sixty
max-sixty reviewed Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of this?

@DimitriPapadopoulos
Copy link
Contributor Author

These imports will only be imported during type checking, not at run time.

@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH001
693876d 
TCH001 Move application import into a type-checking block
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH002
aeb992f 
TCH002 Move third-party import into a type-checking block
@DimitriPapadopoulos
Apply ruff/flake8-type-checking rule TCH003
cf18bcf 
TCH003 Move standard library import into a type-checking block
@DimitriPapadopoulos
Enforce ruff/flake8-type-checking rules (TCH)
a1ae5e9
@max-sixty
Copy link
Collaborator

Yes, though these are very cheap imports.

I'm also cognizant of #9581...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @max-sixty