Enforce ruff/flake8-comprehensions rules (C4) #9724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Nov 6, 2024
| @@ -1167,7 +1167,7 @@ def _validate_and_autodetect_region(self, ds: Dataset) -> Dataset: | |||
| region = self._write_region | |||
|
|
|||
| if region == "auto": | |||
| region = {dim: "auto" for dim in ds.dims} | |||
| region = dict.fromkeys(ds.dims, "auto") | |||
There was a problem hiding this comment.
Why is this form better?
There was a problem hiding this comment.
Good question. I expect that if the rule exists, someone has measured run times and found this form more efficient. However, this has proven false at least once for UP038 (see astral-sh/ruff#7871).
From the C420 rule documentation:
Prefer
dict.fromkeys(iterable)over{value: None for value in iterable}, asdict.fromkeysis more readable and efficient.
There was a problem hiding this comment.
OK, I guess I'm familiar with the existing one, but support doing what is standard.
To the extent it's not yet a standard (that issue suggests it might not be yet), I'd vote with a low weight to push this off...
C409 Unnecessary `tuple` literal passed to `tuple()` (remove the outer call to `tuple()`) C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
C414 Unnecessary `tuple` call within `sorted()`
C416 Unnecessary `dict` comprehension (rewrite using `dict()`) C416 Unnecessary `list` comprehension (rewrite using `list()`)
C417 Unnecessary `map` usage (rewrite using a generator expression)
C419 Unnecessary list comprehension
C420 Unnecessary dict comprehension for iterable; use `dict.fromkeys` instead
DimitriPapadopoulos
force-pushed
the
C4
branch
from
bdc5191
to
b7dcb26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not enforced:
listcomprehension)setcomprehension)listcomprehension (rewrite as asetcomprehension)listliteral (rewrite as asetliteral)dictcall (rewrite as a literal)The reason is that maintainers are often less fond of these rules. I am happy to apply them if there's interest.