-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement dask
methods on DataTree
#9670
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f625f5d
implement `compute` and `load`
keewis 507fb7d
also shallow-copy variables
keewis ce1683a
implement `chunksizes`
keewis f2a4683
add tests for `load`
keewis f0ff30f
add tests for `chunksizes`
keewis d12203c
improve the `load` tests using `DataTree.chunksizes`
keewis dda02ed
add a test for `compute`
keewis 329c689
un-xfail a xpassing test
keewis c9fb461
implement and test `DataTree.chunk`
keewis 0305fc5
link to `Dataset.load`
keewis e2a3a14
use `tree.subtree` to get absolute paths
keewis 7f57ffa
filter out missing dims before delegating to `Dataset.chunk`
keewis 900701b
fix the type hints for `DataTree.chunksizes`
keewis d45dbd0
try using `self.from_dict` instead
keewis 5f88937
type-hint intermediate test variables
keewis b515972
Merge branch 'main' into datatree-dask-methods
keewis 39d95f6
use `_node_dims` instead
keewis 73b4466
raise on unknown chunk dim
keewis 8b35676
check that errors in `chunk` are raised properly
keewis d70f4f0
adapt the docstrings of the new methods
keewis 3e9745f
allow computing / loading unchunked trees
keewis b6c5f9a
reword the `chunksizes` properties
keewis da8df36
also freeze the top-level chunk sizes
keewis b11a1ef
also reword `DataArray.chunksizes`
keewis 53c0897
fix a copy-paste error
keewis f7e31b4
same for `NamedArray.chunksizes`
keewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!