updating group type annotation for netcdf, hdf5, and zarr open_datatree function #9614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headtr1ck
approved these changes
Oct 12, 2024
xarray/backends/h5netcdf_.py
Outdated
| @@ -465,7 +465,7 @@ def open_datatree( | |||
| use_cftime=None, | |||
| decode_timedelta=None, | |||
| format=None, | |||
| group: str | Iterable[str] | Callable | None = None, | |||
| group: str | Callable[[], str] | None = None, | |||
There was a problem hiding this comment.
Is that really the correct Callable signature? Does Callable actually work at all?
There was a problem hiding this comment.
I don't think so. However, this is something I will discuss in the next datatree meeting.
There was a problem hiding this comment.
Callable was a suggestion I had some time ago, but it also is unsupported right now. So I'd also remove that, and possibly add it back when/if we add support for Iterable[str].
|
Feel free to add an entry to whats-new! |
…pen_datatree function
for more information, see https://pre-commit.ci
TomNicholas
added
the
topic-DataTree
TomNicholas
approved these changes
Oct 13, 2024
|
Thanks @aladinor ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
groupparameter does not support Iterable[str] #9597whats-new.rst