Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatree deduplicate setitem #9602

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Datatree deduplicate setitem #9602

merged 2 commits into from
Oct 11, 2024

Conversation

TomNicholas
Copy link
Member

@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Oct 10, 2024
shoyer
shoyer approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks Tom for the quick fix

owenlittlejohns
owenlittlejohns approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TomNicholas TomNicholas merged commit 70a2a55 into pydata:main Oct 11, 2024
32 of 35 checks passed
@TomNicholas TomNicholas deleted the datatree_deduplicate_setitem branch October 11, 2024 02:48
TomNicholas added a commit to shoyer/xarray that referenced this pull request Oct 13, 2024
@TomNicholas
fixed one missed instance of kwarg from pydata#9602
b3a773c
@TomNicholas TomNicholas mentioned this pull request Oct 13, 2024
Merged
TomNicholas added a commit that referenced this pull request Oct 13, 2024
@shoyer @TomNicholas
Rename inherited -> inherit in DataTree.to_dataset (#9615)
93b4859 
* Rename inherited -> inherit in DataTree.to_dataset

* fixed one missed instance of kwarg from #9602

---------

Co-authored-by: Tom Nicholas <tom@cworthy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenlittlejohns owenlittlejohns owenlittlejohns approved these changes

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
DataTree integration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: DataTree allows duplicated inherited coordinates to be set via __setitem__
3 participants
@TomNicholas @shoyer @owenlittlejohns