Skip to content

Make the first argument in DataTree.from_dict positional only #9446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2024
Merged

Make the first argument in DataTree.from_dict positional only #9446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9eb4368
Make the first argument in DataTree.from_dict positional only
shoyer Sep 7, 2024
31575ba
Merge branch 'main' into from-dict-positional
shoyer Sep 7, 2024
e800d88
Merge branch 'main' into from-dict-positional
shoyer Sep 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions xarray/core/datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,6 +1046,7 @@ def drop_nodes(
def from_dict(
cls,
d: Mapping[str, Dataset | DataTree | None],
/,
name: str | None = None,
) -> DataTree:
"""
Expand Down
4 changes: 2 additions & 2 deletions xarray/tests/test_datatree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@ def test_match(self):

def test_filter(self):
simpsons = DataTree.from_dict(
d={
{
"/": xr.Dataset({"age": 83}),
"/Herbert": xr.Dataset({"age": 40}),
"/Homer": xr.Dataset({"age": 39}),
Expand All @@ -1083,7 +1083,7 @@ def test_filter(self):
name="Abe",
)
expected = DataTree.from_dict(
d={
{
"/": xr.Dataset({"age": 83}),
"/Herbert": xr.Dataset({"age": 40}),
"/Homer": xr.Dataset({"age": 39}),
Expand Down
6 changes: 3 additions & 3 deletions xarray/tests/test_datatree_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ def test_not_a_tree(self):
check_isomorphic("s", 1) # type: ignore[arg-type]

def test_different_widths(self):
dt1 = DataTree.from_dict(d={"a": empty})
dt2 = DataTree.from_dict(d={"b": empty, "c": empty})
dt1 = DataTree.from_dict({"a": empty})
dt2 = DataTree.from_dict({"b": empty, "c": empty})
expected_err_str = (
"Number of children on node '/' of the left object: 1\n"
"Number of children on node '/' of the right object: 2"
Expand Down Expand Up @@ -320,7 +320,7 @@ def weighted_mean(ds):

def test_alter_inplace_forbidden(self):
simpsons = DataTree.from_dict(
d={
{
"/": xr.Dataset({"age": 83}),
"/Herbert": xr.Dataset({"age": 40}),
"/Homer": xr.Dataset({"age": 39}),
Expand Down