Skip to content

Allow str in static typing of reindex, ffill etc. #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherian merged 2 commits into from
Jun 30, 2024
Merged

Allow str in static typing of reindex, ffill etc. #9194

dcherian merged 2 commits into from
Jun 30, 2024

Conversation

@headtr1ck
Copy link
Collaborator

@headtr1ck headtr1ck commented Jun 30, 2024 •
edited
Loading

max-sixty
max-sixty approved these changes Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@dcherian dcherian merged commit fff8253 into pydata:main Jun 30, 2024
@headtr1ck headtr1ck deleted the typing-reindex branch July 18, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-sixty max-sixty max-sixty approved these changes

@Illviljan Illviljan Illviljan approved these changes

Assignees

No one assigned

Labels

topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ffill's tolerance argument can be strings

4 participants

@headtr1ck @max-sixty @Illviljan @dcherian