Skip to content

numpy 2 compatibility in the iris code paths #9156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2024
Merged

numpy 2 compatibility in the iris code paths #9156

merged 3 commits into from
Jul 11, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jun 23, 2024

Just like #9136, this attempts to see if there's anything we can / need to do to get our iris tests to run with numpy>=2 (the issue is not iris but cf_units, I believe)

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@keewis keewis added the run-upstream Run upstream CI label Jun 23, 2024
@keewis
Copy link
Collaborator Author

keewis commented Jun 23, 2024 •
edited
Loading

looks like iris depends on netcdf4, so we need to merge #9136 to see if anything fails.

Edit: the most recent commit doesn't seem to cause any additional failing tests, so I'd say that means we're fine? We should definitely merge #9136 first to be sure, though.

@trexfeathers
Copy link

Shout if you need anything from the Iris side 🤜🤛

@keewis
Copy link
Collaborator Author

keewis commented Jul 11, 2024

@trexfeathers, looks like there was nothing to do here.

@keewis keewis merged commit e12aa44 into pydata:main Jul 11, 2024
@keewis keewis deleted the numpy2-iris branch July 11, 2024 09:25
dcherian added a commit to dcherian/xarray that referenced this pull request Jul 11, 2024
@dcherian
Merge branch 'main' into grouper-public-api
c94d9c2 
* main:
  exclude the bots from the release notes (pydata#9235)
  switch the documentation to run with `numpy>=2` (pydata#9177)
  `numpy` 2 compatibility in the iris code paths (pydata#9156)
  `numpy` 2 compatibility in the `netcdf4` and `h5netcdf` backends (pydata#9136)
  Fix time indexing regression in `convert_calendar` (pydata#9192)
  Use duckarray assertions in test_coding_times (pydata#9226)
  Use reshape and ravel from duck_array_ops in coding/times.py (pydata#9225)
  Cleanup test_coding_times.py (pydata#9223)
  Only use necessary dims when creating temporary dataarray (pydata#9206)
  Fix two bugs in DataTree.update() (pydata#9214)
  Use numpy 2.0-compat `np.complex64` dtype in test (pydata#9217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run-upstream Run upstream CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @trexfeathers