Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin nightly zarr to v2 #9050

Merged
merged 3 commits into from
May 30, 2024
Merged

pin nightly zarr to v2 #9050

merged 3 commits into from
May 30, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 29, 2024 •
edited
Loading

Nightly zarr appears to have new dependencies we don't get from the version on conda-forge. Apparently xarray is not ready for zarr v3, yet, so this pins nightly zarr to v2.

Additionally, this allows using ci/install-upstream-wheels.sh if micromamba is not installed.

cc @jhamman

@keewis keewis added the run-upstream Run upstream CI label May 29, 2024
@mathause
Copy link
Collaborator

Nice!

@keewis keewis changed the title explicitly install zarr dependencies pin nightly zarr to v2 May 30, 2024
@jhamman
Copy link
Member

jhamman commented May 30, 2024

Thanks @keewis! Pinning to main is the right thing for now. We will certainly want to change this when we adds support for v3.

@keewis
Copy link
Collaborator Author

keewis commented May 30, 2024

thanks for the confirmation, @jhamman.

@keewis keewis merged commit 0939003 into pydata:main May 30, 2024
24 of 28 checks passed
@keewis keewis deleted the zarr-nightly-deps branch May 30, 2024 14:28
andersy005 pushed a commit that referenced this pull request Jun 14, 2024
@keewis @andersy005
pin nightly zarr to v2 (#9050)
1d8ef90 
* explicitly install new zarr dependencies

* fall back to `mamba` / `conda` if `micromamba` is not installed

* install from `zarr`'s `main` instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
run-upstream Run upstream CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @mathause @jhamman