Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the upstream-dev setup script #8986

Merged
merged 10 commits into from
Apr 30, 2024
Merged

clean up the upstream-dev setup script #8986

merged 10 commits into from
Apr 30, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Apr 30, 2024

In trying to install packages that are compatible with numpy>=2 I added several projects that are built in CI without build isolation (so that they will be built with the nightly version of numpy). That was a temporary workaround, so we should start thinking about cleaning this up.

As it seems numcodecs is now compatible (or uses less of numpy in compiled code, not sure), this is an attempt to see if CI works if we use the version from conda-forge.

bottleneck and cftime now build against numpy>=2.0.0rc1, so we can stop building them without build isolation.

@keewis keewis added the run-upstream Run upstream CI label Apr 30, 2024
`bottleneck` uses the release candidate on PyPI to build `numpy>=2`
compatible wheels.
(same as `bottleneck`: it builds against `numpy>=2.0.0rc1`)
Supposedly `pyarrow>=16.0` is compatible with `numpy>=2`, but I don't
know whether the version on `conda-forge` is built against the release
candidate of `numpy`.
@keewis
Copy link
Collaborator Author

keewis commented Apr 30, 2024

pyarrow still is not built against numpy>=2 on conda-forge (so we can't remove the upstream-dev install, yet), but all the others appear to work now. Which means this is ready for review / merging.

I will note that shapely will raise ImportErrors for the same reason when displaying the installed versions, but we don't use that in our tests, so nothing urgent (i.e. we can wait until it does).

@dcherian dcherian merged commit bfcb0a7 into pydata:main Apr 30, 2024
16 of 19 checks passed
andersy005 added a commit that referenced this pull request Apr 30, 2024
* origin/main:
  clean up the upstream-dev setup script (#8986)
  Skip flaky `test_open_mfdataset_manyfiles` test (#8989)
  Remove `.drop` warning allow (#8988)
  Add notes on when to add ignores to warnings (#8987)
  Docstring and documentation improvement for the Dataset class (#8973)
@keewis keewis deleted the numcodecs branch April 30, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-upstream Run upstream CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants