Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for the pint tests #8983

Merged
merged 9 commits into from
Jun 10, 2024
Merged

fixes for the pint tests #8983

merged 9 commits into from
Jun 10, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Apr 29, 2024 •
edited
Loading

This removes the use of the deprecated numpy.core._exceptions.UFuncError (and multiplication as a way to attach units), and makes sure we run the pint tests in the upstream-dev CI again.

@keewis keewis added the run-upstream Run upstream CI label May 1, 2024
@keewis keewis added the plan to merge Final call for comments label Jun 10, 2024
@dcherian dcherian merged commit 4822bd8 into pydata:main Jun 10, 2024
30 of 34 checks passed
@keewis keewis deleted the pint-numpy2-py3.12 branch June 10, 2024 15:39
andersy005 pushed a commit that referenced this pull request Jun 14, 2024
@keewis @andersy005
fixes for the pint tests (#8983)
fb5c6a7 
* use the `Quantity` constructor instead of multiplying

* manually install `pint` deps into the upstream-dev CI

* stop explicitly installing `pint` dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty left review comments

Assignees
No one assigned
Labels
plan to merge Final call for comments run-upstream Run upstream CI
Projects
numpy2 compat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @max-sixty @dcherian