-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more engine environment tricks in preparation for numpy>=2
#8978
Conversation
@kmuehlbauer, I might need some help here... There's two Once we merge this will re-enable the |
This comment was marked as resolved.
This comment was marked as resolved.
Thanks @keewis for taking care. Yes, this test was probably created with the assumption of conda-forge environment in mind. I'll need to look into this how to check for ros3 within h5py. We might use This is from the top of my head, so please double-check. |
no, just that we don't run upstream-dev
Thanks a lot, I'll see what I can do. |
that appears to have done it! Which means this is ready for review and merging. Edit: or maybe not... another condition I got wrong. Should work now, though. |
@keewis 💯 👍 Great to have h5netcdf upstream testing back! |
`numpy.strings` exists since `numpy>=2`
lots of new upstream-dev failures because of the new internal warning filter. Most of these are resolved in #8939 (so we should try to resolve the typing issues that currently block it), with the remaining one being a warning about deprecating the cross product between 2D vectors (from the Edit: the macos 3.11 appears to be flaky as usual for the macos CI. I'll go ahead and merge anyways. |
Turns out
pydap
also needs to build withnumpy>=2
. Until it does, we should remove it from the upstream-dev environment. Also,numcodecs
build-depends onsetuptools-scm
.And finally, the
h5py
nightlies might supportnumpy>=2
(h5py>=3.11
supposedly isnumpy>=2
compatible), so once again I'll try and see if CI passes.