stop pruning datatree_ directory from distribution #8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Quick fixup of some typing. Removes mypy exclusions for datatree_
flamingbear
force-pushed
the
stop-stripping-datatree_
branch
from
771a8d5
to
84d23be
Compare
keewis
reviewed
Apr 18, 2024
There was a problem hiding this comment.
looks fine to me. Just a comment: we probably don't want to include anything other than xarray.datatree_.datatree. I've suggested a change (which I didn't verify) which would only take the old datatree python code.
(note that these are merely suggestions to keep the wheels / source dists as small as possible, so if you have reason against them I'm fine with dropping them)
owenlittlejohns
approved these changes
Apr 18, 2024
exclude docs from mypy tests Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
keewis
reviewed
Apr 19, 2024
try again to include just code from datatree_ Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
keewis
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the directive that strips out the datatree_ directory from the xarray distribution.
It also cleans a few typing errors and removes exceptions for the datatree_ directory for mypy.
It does NOT remove the exception for pre-commit config.
xarray/datatree_missing in 2024.2.0 sdist #8768