Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-ci] NamedArray: Add lazy indexing array refactoring plan #8775

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Feb 22, 2024

This adds a proposal for decoupling the lazy indexing array machinery, indexing adapter machinery, and Variable's setitem and getitem methods, so that the latter can be migrated to NamedArray.

cc @andersy005

@dcherian dcherian requested a review from shoyer February 22, 2024 04:25
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me 👍🏽

@andersy005 andersy005 enabled auto-merge (squash) February 23, 2024 21:33
@andersy005 andersy005 changed the title NamedArray: Add lazy indexing array refactoring plan [skip-ci] NamedArray: Add lazy indexing array refactoring plan Feb 23, 2024
@andersy005 andersy005 merged commit 01f7b4f into pydata:main Feb 23, 2024
17 checks passed
@dcherian dcherian deleted the lazy-array-refactor-notes branch April 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants