Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use CopyOnWriteArray wrapper on BackendArrays #8712

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+18 −1
Open

Only use CopyOnWriteArray wrapper on BackendArrays #8712

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca17266
only wrap BackendArrays in CopyOnWriteArray
TomNicholas Feb 6, 2024
99a37be
only wrap BackendArrays in CopyOnWriteArray
TomNicholas Feb 6, 2024
c80fefd
document how CopyOnWrite happens for BackendArray subclasses
TomNicholas Feb 6, 2024
3f2b82d
Merge branch 'only-copyonwrite-backendarrays' of https://github.com/T…
TomNicholas Feb 6, 2024
22ec10f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
only wrap BackendArrays in CopyOnWriteArray
  • Loading branch information
@TomNicholas
TomNicholas committed Feb 6, 2024
commit ca1726601393cb6d3555b59af8a59b674cb54da4
5 changes: 4 additions & 1 deletion xarray/backends/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,10 @@ def _protect_dataset_variables_inplace(dataset, cache):
for name, variable in dataset.variables.items():
if name not in dataset._indexes:
# no need to protect IndexVariable objects
data = indexing.CopyOnWriteArray(variable._data)
if isinstance(variable._data, backends.BackendArray):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not right to me. We are in backends/api.py these should all be BackendArrays.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way that BackendArray is presented in How to add a new backend strongly implies that using BackendArray is optional. In the KerchunkArray case I specifically don't want to use BackendArray, even though I do want to write a backend (from #8714 (comment)):

my KerchunkArray case is interesting because I don't want to use BackendArray (I have no use for CopyOnWrite because I'm never loading bytes, nor for Lazy indexing (I can't index into the KerchunkArray at all).

data = indexing.CopyOnWriteArray(variable._data)
else:
data = variable.data
if cache:
data = indexing.MemoryCachedArray(data)
variable.data = data
Expand Down