Convert 360_day calendars by choosing random dates to drop or add #8603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulemahal
changed the title
|
@spencerkclark |
spencerkclark
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Thanks @aulemahal—sorry for taking so long to take a look at this. The tests / implementation look reasonable.
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
|
@spencerkclark I think everything here is done. Thanks! |
|
Yup looks good—thanks! |
dcherian
added a commit
to djhoese/xarray
that referenced
this pull request
Apr 18, 2024
* main: (feat): Support for `pandas` `ExtensionArray` (pydata#8723) Migrate datatree mapping.py (pydata#8948) Add mypy to dev dependencies (pydata#8947) Convert 360_day calendars by choosing random dates to drop or add (pydata#8603)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstSmall PR to add a new "method" to convert to and from 360_day calendars. The current two methods (chosen with the
align_onkeyword) will always remove or add the same day-of-year for all years of the same length.This new option will randomly chose the days, one for each fifth of the year (72-days period). It emulates the method of the LOCA datasets (see web page and article ). February 29th is always removed/added when the source/target is a leap year.
I copied the implementation from xclim (which I wrote), see code here .