Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to specify weights in xr.corr() and xr.cov() #8527

Merged
merged 20 commits into from
Dec 12, 2023
Merged

Added option to specify weights in xr.corr() and xr.cov() #8527

merged 20 commits into from
Dec 12, 2023

Commits on Dec 6, 2023

  1. Added function _weighted_cov_corr and modified cov and corr to call i… 

    …t if parameter weights is not None
    Llorenc Lledo authored and Llorenc Lledo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    88c0726 View commit details
    Browse the repository at this point in the history

  2. Correct two indentation errors

    Llorenc Lledo authored and Llorenc Lledo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    0d2f548 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    31302a7 View commit details
    Browse the repository at this point in the history

  4. Stupid typo

    Llorenc Lledo authored and Llorenc Lledo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    d801d4a View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    042bb28 View commit details
    Browse the repository at this point in the history

  6. Remove the min_count argument from mean

    Llorenc Lledo authored and Llorenc Lledo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    fcf8632 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'refs/remotes/origin/weighted_cov_corr' … 

    …into weighted_cov_corr
    Llorenc Lledo authored and Llorenc Lledo committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    4d961e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Unified the code for weighted and unweighted _cov_corr

    Llorenc Lledo authored and Llorenc Lledo committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d35fa97 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Remove old _cov_corr function after checking that new version produce… 

    …s same results when weights=None or weights=xr.DataArray(1)
    Llorenc Lledo authored and Llorenc Lledo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7c646a7 View commit details
    Browse the repository at this point in the history

  2. Added examples that use weights for cov and corr

    Llorenc Lledo authored and Llorenc Lledo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    20936e6 View commit details
    Browse the repository at this point in the history

  3. Added two tests for weighted correlation and covariance

    Llorenc Lledo authored and Llorenc Lledo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3ce7d6e View commit details
    Browse the repository at this point in the history

  4. Fix error in mypy, allow None as weights type.

    Llorenc Lledo authored and Llorenc Lledo committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f7bc41a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into weighted_cov_corr

    @max-sixty
    max-sixty authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    827faad View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Update xarray/core/computation.py 

    Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
    @lluritu @max-sixty
    lluritu and max-sixty authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d61c1ab View commit details
    Browse the repository at this point in the history

  2. Update xarray/core/computation.py 

    Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
    @lluritu @max-sixty
    lluritu and max-sixty authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    db1c5c0 View commit details
    Browse the repository at this point in the history

  3. Info on new options for cov and corr in whatsnew

    Llorenc Lledo authored and Llorenc Lledo committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    b5694a1 View commit details
    Browse the repository at this point in the history

  4. Info on new options for cov and corr in whatsnew

    Llorenc Lledo authored and Llorenc Lledo committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    f63acfa View commit details
    Browse the repository at this point in the history

  5. Fix typing

    @max-sixty
    max-sixty committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    71cfac8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into weighted_cov_corr

    @max-sixty
    max-sixty authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    f086ff5 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Merge branch 'main' into weighted_cov_corr

    @max-sixty
    max-sixty authored Dec 12, 2023
    Configuration menu
    Copy the full SHA
    2a1467b View commit details
    Browse the repository at this point in the history