Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstrings for combine_by_coords #8471

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Fix docstrings for combine_by_coords #8471

merged 3 commits into from
Dec 2, 2023

Conversation

gtrevisan
Copy link
Contributor

Docstrings for combine_attrs parameter show a wrong default value, which is no_conflicts, not drop.

def combine_by_coords(
data_objects: Iterable[Dataset | DataArray] = [],
compat: CompatOptions = "no_conflicts",
data_vars: Literal["all", "minimal", "different"] | list[str] = "all",
coords: str = "different",
fill_value: object = dtypes.NA,
join: JoinOptions = "outer",
combine_attrs: CombineAttrsOptions = "no_conflicts",
) -> Dataset | DataArray:

Update default for `combine_attrs` parameter.
@github-actions github-actions bot added the topic-combine combine/concat/merge label Nov 20, 2023
@headtr1ck
Copy link
Collaborator

Thanks for this nice little PR :)

Just a tip for next time: make these changes on a branch in your forked repo. Otherwise you will run into problems for your next contribution!

@headtr1ck headtr1ck merged commit 1acdb5e into pydata:main Dec 2, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-combine combine/concat/merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants