-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant metadata reads in ZarrArrayWrapper
#8297
Conversation
Modify ZarrArrayWrapper to avoid re-reading metadata each time data is read from the array.
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion but this looks great. No doubt this is going to really improve performance when reading data with zarr.
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good, thanks!
Maybe some get_array()
calls can be replaced by _array
, but that's really minor.
You should add an entry in whats-new!
And as a bonus you could add a benchmark, but that's really optional (seems like there are only netcdf Io benchmarks right now).
Thanks @headtr1ck!
Great, this has been done.
I didn't do this. I'll try to add a note to #8290 of a before/after scenario, to illustrate the impact of the reduced requests. |
Modify ZarrArrayWrapper to avoid re-reading metadata each time data is read from the array.
whats-new.rst
api.rst