#6891 issue resolved #7679
#6891 issue resolved #7679
Conversation
There was a problem hiding this comment.
Before I add a comment on every occasion: You probably replaced all **kwargs by kwargs, and therefore too many.
In a lot of functions the use of **kwargs is still correct.
Also, please use the provided template for the PR description, especially the "Closes #issuenumber" part and add a more descriptive title.
| @@ -7681,7 +7681,7 @@ def map_blocks( | |||
| ``func`` can work on numpy arrays, it is recommended to use ``apply_ufunc``. | |||
|
|
|||
| If none of the variables in this object is backed by dask arrays, calling this function is | |||
| equivalent to calling ``func(obj, *args, **kwargs)``. | |||
| equivalent to calling ``func(obj, *args, kwargs)``. | |||
There was a problem hiding this comment.
I think the previous version was correct.
There was a problem hiding this comment.
Okay I'll look into it right away. If you have any advice, please let me know.
There was a problem hiding this comment.
I think you have to start over and only apply the changes in the docstring which you mentioned in the PR description.
All the other changes are actually wrong, since the current way is correct.
| @@ -7534,7 +7534,7 @@ def filter_by_attrs(self: T_Dataset, **kwargs) -> T_Dataset: | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| **kwargs | |||
| kwargs | |||
There was a problem hiding this comment.
Also here the previous version is correct, see the function signature.
Closes #6891. Changed **kwargs to kwargs in docstrings of 2 files (dataarray.py & dataset.py).