Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type in benchmarks/merge.py #7235

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Fix type in benchmarks/merge.py #7235

merged 1 commit into from
Oct 29, 2022

Conversation

hmaarrfk
Copy link
Contributor

I don't think this affects what is displayed that is determined by param_names

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@hmaarrfk
Fix type in benchmarks/merge.py
62c3b91 
I don't think this affects what is displayed that is determined by param_names
@github-actions github-actions bot added run-benchmark Run the ASV benchmark workflow topic-performance labels Oct 29, 2022
headtr1ck
headtr1ck approved these changes Oct 29, 2022
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

@headtr1ck headtr1ck merged commit 2608c40 into pydata:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
run-benchmark Run the ASV benchmark workflow topic-performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmaarrfk @headtr1ck