Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CF decoding #6812

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Improved CF decoding #6812

wants to merge 5 commits into from

Commits on Jul 19, 2022

  1. Make code match comments - use 64bit float

    @mankoff
    mankoff committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    2a5686c View commit details
    Browse the repository at this point in the history

  2. Fix logic bug 

    Line above this removes 'add_offset' from 'attrs' (if it exists), so
'"add_offset" in attrs' should always be false. It was moved into
'encoding' so let's check for it there.
    @mankoff
    mankoff committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    108586e View commit details
    Browse the repository at this point in the history

  3. Fixed test suite for new float64 dtype 

    Modified _choose_float_dtype
+ Returns float32 if inputs are float16 or float32
+ Returns float64 if inputs are int
    @mankoff
    mankoff committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    4eedd29 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2022

  1. Undo 2a5686c per correction from @dcherian 

    pydata#6812 (review)
    @mankoff
    mankoff committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    312acda View commit details
    Browse the repository at this point in the history

  2. Rewrite per CF standards 

    https://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/ch08.html

Split encoding and decoding for now.
    @mankoff
    mankoff committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    4615720 View commit details
    Browse the repository at this point in the history