Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the sync script #5573

Merged
merged 2 commits into from
Jul 11, 2021
Merged

remove the sync script #5573

merged 2 commits into from
Jul 11, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 4, 2021

follow-up to #5468. We removed the external version file but the sync script is still run in CI, which obviously fails and causes the report to be stripped from the PR comment.

For a future PR / investigation: pre-commit allows installing dependencies from the language's package index (e.g. PyPI for python), but packages installed using that method are not updated until the hook is updated / reinstalled. For blackdoc we were thinking about pinning black at some point so we could work around that by synchronizing the version with the hook version, but this is probably more work than it is worth. I guess this means we have to wait on pre-commit to fix this and in the meantime we'll probably have to tell people to clean their pre-commit caches on updates for black and numpy...

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2021

Unit Test Results

         6 files  ±0           6 suites  ±0   51m 35s ⏱️ ±0s
16 172 tests ±0  14 441 ✔️ ±0  1 731 💤 ±0  0 ❌ ±0 
90 228 runs  ±0  82 077 ✔️ ±0  8 151 💤 ±0  0 ❌ ±0 

Results for commit 7f722cf. ± Comparison against base commit 7f722cf.

♻️ This comment has been updated with latest results.

@keewis keewis merged commit 7f722cf into pydata:main Jul 11, 2021
@keewis keewis deleted the fix-autoupdate branch July 11, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant