Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

differentiate should not cast to numpy.array #5408

Merged
merged 8 commits into from
Jun 7, 2021
Merged

differentiate should not cast to numpy.array #5408

merged 8 commits into from
Jun 7, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 31, 2021 •
edited
Loading

Apparently the test coverage was not high enough: we were passing a Variable object to numpy.gradient. This only adds tests for DataArray.differentiate because Dataset.differentiate doesn't seem to be as easy to check (the axis might be different).

max-sixty
max-sixty approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot, thanks @keewis !

@keewis keewis added the plan to merge Final call for comments label Jun 6, 2021
@dcherian dcherian merged commit da0489f into pydata:master Jun 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit da0489f. ± Comparison against base commit da0489f.

@keewis keewis deleted the differentiate-with-units branch June 9, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

diff support
3 participants
@keewis @dcherian @max-sixty