Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the variable repr with display_expand_data=False #5406

Merged
merged 3 commits into from
May 31, 2021
Merged

fix the variable repr with display_expand_data=False #5406

merged 3 commits into from
May 31, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 30, 2021 •
edited
Loading

In #5235 we seem to have accidentally broken the repr of Variable objects with display_expand_data=False. I don't think Variable objects benefit from the collapsed view, so the easiest fix seems to be to always use short_data_repr for Variable objects.

  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

max-sixty
max-sixty approved these changes May 30, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@keewis keewis merged commit 83eda1a into pydata:master May 31, 2021
@keewis keewis deleted the fix-variable-repr branch May 31, 2021 11:48
@keewis
Copy link
Collaborator Author

keewis commented May 31, 2021

thanks for the review, @max-sixty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keewis @max-sixty