Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the error message when pooch is not installed #5312

Merged
merged 3 commits into from
May 17, 2021
Merged

improve the error message when pooch is not installed #5312

merged 3 commits into from
May 17, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented May 14, 2021

Since it seems difficult to fix the situation using the package manager, this improves the error message by explicitly suggesting to install pooch.

shoyer
shoyer reviewed May 14, 2021
View reviewed changes
xarray/tutorial.py Outdated Show resolved Hide resolved
max-sixty
max-sixty approved these changes May 16, 2021
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@keewis keewis merged commit 2bb5d20 into pydata:master May 17, 2021
@keewis keewis deleted the pooch-error branch May 17, 2021 12:56
@keewis
Copy link
Collaborator Author

keewis commented May 17, 2021

thanks for the reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @shoyer @max-sixty